PHP 8.5 support #1221
PHP 8.5 support #1221
Conversation
WalkthroughAdds a new GitHub Actions job Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions
participant Shared as contributte/.github/.../nette-tester-mysql.yml
note over GH,Shared `#D6F5D6`: New test85 job invokes shared workflow with PHP 8.5
GH->>Shared: dispatch (php: "8.5", database: "tests")
alt tests pass
Shared-->>GH: success
else tests fail
Shared-->>GH: failure
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
radimvaculik
force-pushed
the
feature/php85
branch
from
0a16220 to
3d0792e
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/tests.yml(1 hunks)composer.json(1 hunks)
🔇 Additional comments (1)
.github/workflows/tests.yml (1)
14-19: Verify external workflow supports PHP 8.5 nightly builds.PHP 8.5 is available on GitHub Actions as a nightly/development version via the shivammathur/setup-php action. The code itself (lines 14-19) is correct and consistent with existing test jobs (test84, test83, etc.).
However, the actual PHP 8.5 support depends on the external shared workflow
contributte/.github/.github/workflows/nette-tester-mysql.yml@master. Since this workflow is in an external repository, verify that it:
- Uses a recent version of shivammathur/setup-php that supports PHP 8.5 nightly
- Properly handles the
php: "8.5"input parameterThe workflow is proven to work with PHP 8.4, suggesting compatibility, but explicit verification of PHP 8.5 nightly support is recommended before merging.
|
Failing as LeanMapper has PHP 7.4-8.4 |
radimvaculik
force-pushed
the
feature/php85
branch
from
3d0792e to
7c55aeb
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
.github/workflows/phpstan.yml (1)
18-18: Dependency compatibility concern: LeanMapper does not support PHP 8.5.This workflow will fail to install dependencies on PHP 8.5 due to LeanMapper incompatibility (referenced in the PR comments and LeanMapper issue #171).
.github/workflows/coverage.yml (1)
18-18: Critical blocker: PHP 8.5 test execution is not possible with current dependencies.The coverage workflow will fail during test execution because LeanMapper—a transitive dependency of the project—does not support PHP 8.5 (per LeanMapper issue #171 cited in the PR comments). This blocks the PR from merging.
To proceed:
- Coordinate with the LeanMapper maintainers for PHP 8.5 support, or
- Replace or upgrade LeanMapper if a compatible version or alternative exists, or
- Defer PHP 8.5 support until the dependency is compatible.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
.github/workflows/codesniffer.yml(1 hunks).github/workflows/coverage.yml(1 hunks).github/workflows/phpstan.yml(1 hunks).github/workflows/tests.yml(1 hunks)README.md(1 hunks)composer.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- composer.json
- .github/workflows/tests.yml
|
@f3l1x WDYT? |
|
LGTM, let's do it. |
|
@f3l1x Can't merge my own PR 🙈 |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.